make docker results in broken image

[discordianfish]

make docker runs promu build which creates a binary with cgo enabled for which the base image doesn't include the necessary shared libs.

[discordianfish]

Root cause: prometheus/promu#60
We should probably just convert the makefile to use promu crossbuild which results in a statically linked binary.

[taion809]

I was able to fix this with a multi-stage docker build. If that is acceptable I can push up my changes for review.

[discordianfish]

@taion809 Oh cool, in general yes! We should just make sure to not diverge too much from how Prometheus is built and it needs to work for cross compilation etc.

[taion809]

In that case I’ll push a branch up for review. The change made doesn’t change the makefile or the Use of promu so it should be ok :)

…

On Sat, Oct 21, 2017 at 10:45 AM discordianfish ***@***.***> wrote: @taion809 <https://github.com/taion809> Oh cool, in general yes! We should just make sure to not diverge too much from how Prometheus is built and it needs to work for cross compilation etc. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3109 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE7nIx5Z9G2PQZ41X6vkqbUvfuKRXdQDks5sugN-gaJpZM4PBlrn> .

[simonpasquier]

@fish IIUC this issue isn't relevant anymore. Do you think it can be closed?

[discordianfish]

@simonpasquier Ah, yah I think this can be closed. Thanks for the ping!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.