Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-repair attempt for LevelDB on corruption? #3120

Closed
joernhees opened this Issue Aug 27, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@joernhees
Copy link

joernhees commented Aug 27, 2017

I'm using prometheus as part of a GitLab CE Omnibus installation... every now and then the leveldb behind it seems to go corrupt ( https://gitlab.com/gitlab-org/gitlab-ce/issues/37092 ).

While i think that the problem probably lies on gitlab's side by swallowing a TERM signal or the likes, i wonder: why doesn't prometheus (in production) try to auto-repair the DB?

In the current state i loose way more info by prometheus being down and not logging than i'd loose by minor DB inconsistencies, no?

@joernhees joernhees changed the title auto-repair attempt for DB on corruption? auto-repair attempt for LevelDB on corruption? Aug 27, 2017

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Aug 28, 2017

LevelDB will not be used anymore in v2.0 of Prometheus. There is very little incentive to invest significant work in improving LevelDB handling at this point.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Aug 28, 2017

If anybody want's to take this, please let me know. Otherwise, I'll close as "won't fix".

@beorn7 beorn7 closed this Aug 29, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.