Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIngress discovery: expected Ingress object type #3141
Comments
grobie
added
component/service discovery
kind/bug
labels
Sep 5, 2017
grobie
assigned
discordianfish
Sep 5, 2017
discordianfish
referenced this issue
Sep 6, 2017
Merged
k8s: Use versioned struct for ingress discovery #3142
fabxc
closed this
in
#3142
Sep 7, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
stibi commentedSep 5, 2017
Hello,
I'm testing the new ingress discovery support (prometheus/docs#821) and I see this error in prometheus server log:
My wild guess is a wrong type here:
prometheus/discovery/kubernetes/kubernetes.go
Line 247 in 70f3d1e
When I changed it to
&v1beta1.Ingress{}, it started working…but I'm not a Go developer and I'm very far from understanding the code, so maybe this is not the correct patch.