Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for Windows images #3148

Closed
sixeyed opened this Issue Sep 7, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@sixeyed
Copy link

sixeyed commented Sep 7, 2017

** This is a feature request **

It would be great to have Windows versions of the official image.

I have a sample Windows Dockerfile here which works well, but it takes a different approach from the Linux image. The Windows version deploys the published release rather than building from source.

Looking for feedback - I'm happy to maintain the Windows variants, and I can also set up CI (it would need to be AppVeyor at this stage, as they're the only service to provide Windows agents).

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Sep 9, 2017

Soo, we have another request for a custom Docker image following #2693. I'm not sure a generic approach via promu will work in all cases. How do people feel about just adding new Dockerfiles everytime someone contributes one?

@juliusv @brian-brazil @fabxc

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Sep 10, 2017

I think we need to support this in a standard way everywhere, or nowhere. We've had a few of these requests, how many different archs are we going to be asked for?

For Windows in particular, given that none of us are Windows people will we be able to maintain this?

@sixeyed

This comment has been minimized.

Copy link
Author

sixeyed commented Sep 10, 2017

Fair point @brian-brazil - but Windows has quite a large user base :) I'm happy to maintain the Windows variants. I do the same with the NATS image, I did the original Dockerfile and when they're prepping a release I help with the Windows testing.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Mar 8, 2018

This falls under prometheus/promu#89

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.