Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDockerfile for Windows images #3148
Comments
This comment has been minimized.
This comment has been minimized.
|
Soo, we have another request for a custom Docker image following #2693. I'm not sure a generic approach via promu will work in all cases. How do people feel about just adding new Dockerfiles everytime someone contributes one? |
This comment has been minimized.
This comment has been minimized.
|
I think we need to support this in a standard way everywhere, or nowhere. We've had a few of these requests, how many different archs are we going to be asked for? For Windows in particular, given that none of us are Windows people will we be able to maintain this? |
This comment has been minimized.
This comment has been minimized.
|
Fair point @brian-brazil - but Windows has quite a large user base :) I'm happy to maintain the Windows variants. I do the same with the NATS image, I did the original Dockerfile and when they're prepping a release I help with the Windows testing. |
brian-brazil
added
kind/enhancement
priority/Pmaybe
labels
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
|
This falls under prometheus/promu#89 |
brian-brazil
closed this
Mar 8, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
sixeyed commentedSep 7, 2017
** This is a feature request **
It would be great to have Windows versions of the official image.
I have a sample Windows Dockerfile here which works well, but it takes a different approach from the Linux image. The Windows version deploys the published release rather than building from source.
Looking for feedback - I'm happy to maintain the Windows variants, and I can also set up CI (it would need to be AppVeyor at this stage, as they're the only service to provide Windows agents).