Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support socks5 proxy in proxy_url #3164

Closed
thomasf opened this Issue Sep 13, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@thomasf
Copy link

thomasf commented Sep 13, 2017

since go1.9 supports socks5 by default the first prometheus release compiled w. 1.9 will support this..

related issue: QubitProducts/exporter_exporter#9

@thomasf thomasf changed the title Support socks5 proxy for proxy_url. Support socks5 proxy in proxy_url Sep 13, 2017

@thomasf

This comment has been minimized.

Copy link
Author

thomasf commented Oct 8, 2017

prometheus 1.8 is compiled with go 1.9, right? If so this should be fixed now.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Oct 8, 2017

@thomasf 1.9.1 even. Cool, can you confirm?

@thomasf

This comment has been minimized.

Copy link
Author

thomasf commented Oct 8, 2017

I tested the linux/amd64 binary download and proxy_url: "socks5://localhost:3000" worked fine.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Oct 8, 2017

Thanks!

@grobie grobie closed this Oct 8, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.