Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular (repository) dependency with tsdb #3197

Closed
TheTincho opened this Issue Sep 20, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@TheTincho
Copy link
Contributor

TheTincho commented Sep 20, 2017

Hi,

I am starting to prepare the Debian packages for 2.0, including packaging new dependencies like prometheus/tsdb. While doing that I notice that it depends on prometheus/prometheus/pkg, thus making packaging an order of magnitude more complex.

Wouldn't it make sense to move this to common?

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Sep 21, 2017

This is just a testing dependency so we can conveniently read an input file of test data.
I'd rather not move pkg/textparse to the common repository (or anything anymore really).

Do you have to include testing deps? I suppose I'd then rather just make those use the common parser, even though it's a bit more hassle to use.

@TheTincho

This comment has been minimized.

Copy link
Contributor Author

TheTincho commented Sep 21, 2017

I had not noticed it was only for tests. But since we run all tests during build, I need to either disable the tests or include the dep...

@gouthamve

This comment has been minimized.

Copy link
Member

gouthamve commented Jan 18, 2018

@gouthamve gouthamve closed this Jan 18, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.