Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCircular (repository) dependency with tsdb #3197
Comments
This comment has been minimized.
This comment has been minimized.
|
This is just a testing dependency so we can conveniently read an input file of test data. Do you have to include testing deps? I suppose I'd then rather just make those use the common parser, even though it's a bit more hassle to use. |
This comment has been minimized.
This comment has been minimized.
|
I had not noticed it was only for tests. But since we run all tests during build, I need to either disable the tests or include the dep... |
brian-brazil
added
kind/cleanup
priority/Pmaybe
labels
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
|
Closed in prometheus/tsdb#226 |
gouthamve
closed this
Jan 18, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
TheTincho commentedSep 20, 2017
Hi,
I am starting to prepare the Debian packages for 2.0, including packaging new dependencies like
prometheus/tsdb. While doing that I notice that it depends onprometheus/prometheus/pkg, thus making packaging an order of magnitude more complex.Wouldn't it make sense to move this to common?