Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upmultiarch support for Docker official image #3203
Comments
This comment has been minimized.
This comment has been minimized.
alexellis
commented
Sep 21, 2017
|
There is already a 64-bit ARM Prometheus binary release, so this should be relatively straight-forward - i.e. placing that binary into a container and adding the default configuration. In terms of the "multi-arch" images - this is done through a manifest file which contains a map of named images and what architecture they are for. The first part is more important than this one, but both would be great. |
brian-brazil
added
kind/enhancement
priority/Pmaybe
labels
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
vaibhavsood
commented
Sep 28, 2017
|
+1 for ppc64le. prometheus has a ppc64le binary as well so that be included too. I'm willing to help out with any ppc64le changes that may be needed to support an official ppc64le Docker image |
This comment has been minimized.
This comment has been minimized.
|
Attn @tianon who may be able to provide some guidance as to how to do this the easiest way. |
This comment has been minimized.
This comment has been minimized.
tianon
commented
Sep 28, 2017
|
With the official images, we try very hard to keep our multiarch images building all architectures from a single As for actually pushing them with a manifest list (so that, for example, For the official images, we use a separate namespace per architecture (https://github.com/docker-library/official-images#architectures-other-than-amd64), but I know at least the LinuxKit folks simply use separate tags per architecture in the same repository (https://hub.docker.com/r/linuxkit/kernel/tags/). |
This comment has been minimized.
This comment has been minimized.
|
I need to take a look at this and see how we can integrate it in our build process. |
This comment has been minimized.
This comment has been minimized.
|
Thanks @sdurrheimer - would it make more sense to open an issue in https://github.com/prometheus/promu to track it there? |
This comment has been minimized.
This comment has been minimized.
|
#3619 looks like a related issue. |
This comment has been minimized.
This comment has been minimized.
alexellis
commented
Jan 4, 2018
|
Ping on thread. The community really needs this - other key projects are adopting multi-arch but I'm having to maintain custom hacks and images to work with Prometheus. Can we help you in some way with this for the greater good? |
This comment has been minimized.
This comment has been minimized.
|
I understand a PR for promu would be the next step. |
This comment has been minimized.
This comment has been minimized.
|
Closing this issue here, in favor of the issue (and hopefully forthcoming PR) in |
vielmetti
closed this
Jan 4, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
vielmetti commentedSep 21, 2017
•
edited
Docker now has support for transparently providing multi-architecture builds for official images. The
mquerytool at https://github.com/estesp/mquery gives one way to query current status, and the source code for mquery gives an example of using a CI system to produce this.I'd like Prometheus to provide a Docker image that works on as many supported architectures as possible, including and especially arm64.
What did you do?
What did you expect to see?
Multi-architecture support with a "fat manifest" pointing to all supported Prometheus binaries from official image.
What did you see instead? Under which circumstances?
Only amd64 support in official image.