Regression: Prometheus 2.0 sends no HTTP Accept header

[grobie]

What did you do?

Pointed prometheus 2.0.0-beta.5 against our existing services.

What did you expect to see?

Metrics being scraped.

What did you see instead? Under which circumstances?

Nothing gets scraped, as services with a strict HTTP server implementation respond with 406 to a HTTP request without an Accept header.

---

I'd vote to keep the changes in content-negotiation to a minimum. The Prometheus server doesn't accept all formats, in fact version 2.0 only accepts a single format, which is text/plain; version=0.0.4.

[grobie]

To be fair, the HTTP spec actually says If no Accept header field is present, then it is assumed that the client accepts all media types.. We have several applications not behaving that way though. I'm questioning it's worth dropping the header and implying a */* as the server does not accept everything.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.