Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upConfirm annotations of resolved alert have appropriate semantics. #3308
Comments
This comment has been minimized.
This comment has been minimized.
|
We never send the value with alerts. Can you give more detail on what you're asking for? |
brian-brazil
added
the
kind/more-info-needed
label
Oct 18, 2017
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil ALERT memory_use_warning |
This comment has been minimized.
This comment has been minimized.
|
The alertmanager doesn't remember previous annotations, it only has the most recent alert to go on - which is the one from the resolved alert. This is working as expected. |
brian-brazil
closed this
Oct 19, 2017
brian-brazil
added
kind/question
and removed
kind/more-info-needed
labels
Oct 19, 2017
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil , I know alertmanager doesn't remember previous annotations, what I understand is the prometheus updated the "endsAt" parameter, after send the notification to the alertmanager, then the alertmanager consider the notification as "Resolved". What I want is when the prometheus update the "endsAt", it update the "value" at the same time. |
brian-brazil
reopened this
Oct 20, 2017
This comment has been minimized.
This comment has been minimized.
|
That'd need to be looked into further |
brian-brazil
added
component/notify
kind/enhancement
priority/Pmaybe
and removed
kind/question
labels
Oct 20, 2017
brian-brazil
changed the title
Resolved message send current resolved $value, instead last firing state $value
Confirm annotations of resolved alert have appropriate semantics.
Oct 20, 2017
brian-brazil
referenced this issue
Feb 2, 2018
Closed
The recovery alarm cannot display the current value. #3759
This comment has been minimized.
This comment has been minimized.
|
I've checked our logic, it's working as expected. |
brian-brazil
closed this
Mar 3, 2018
This comment has been minimized.
This comment has been minimized.
eskp
commented
Mar 4, 2018
|
Any way to get the updated value in the resolve notification then? |
This comment has been minimized.
This comment has been minimized.
ojle
commented
Mar 7, 2019
@brian-brazil |
This comment has been minimized.
This comment has been minimized.
|
If you read that blog post, you'll see that this simply isn't possible. |
tangr commentedOct 18, 2017
The alert resolved rule notification send the $value with last firing state value, it should be better send the current $value instead, or the last resolved state value, then the resolved notification will be much useful.
https://github.com/prometheus/prometheus/blob/master/notifier/notifier.go#L87-100
Environment
Linux 3.10.0-514.26.2.el7.centos.plus.x86_64 x86_64
1.8.0
0.8.0