Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAutocomplete on /graph interface slow with large numbers of metricnames #3321
Comments
This comment has been minimized.
This comment has been minimized.
|
Dupe of #2119 |
brian-brazil
closed this
Oct 20, 2017
This comment has been minimized.
This comment has been minimized.
|
This is actually not a duplicate, this is a separate issue. The linked issue (#2119) is causing the browser to crash and requesting an addition of a limit to the API. This issue is not showing as the browser crashing, but just that the javascript in the UI is slow. More interestingly (and as mentioned in the original issue description) the same number of metrics showing up in the response works fine performance-wise in grafana. So, to re-iterate: this issue is client-side javascript slowness as the typeahead javascript library currently in use is horribly inefficient at handling large numbers of metrics (where there are many others-- including one example linked above) that handles it just fine. |
This comment has been minimized.
This comment has been minimized.
alkar
commented
Nov 21, 2017
|
Experiencing the same, running v2.0.0. |
This comment has been minimized.
This comment has been minimized.
Stono
commented
Jun 15, 2018
|
+1 to this, can we get it reopened? |
This comment has been minimized.
This comment has been minimized.
v1dlak
commented
Dec 29, 2018
|
Do anybody have some workaround for this (for example some greasemonkey script) ? @jacksontj @Stono |
This comment has been minimized.
This comment has been minimized.
|
Indeed, this is not a dupe of #2119 at all (that was about expression query results), reopening. |
juliusv
reopened this
Dec 29, 2018
juliusv
added
kind/enhancement
component/ui
labels
Dec 29, 2018
This comment has been minimized.
This comment has been minimized.
|
The discussion on #2119 is about autocomplete. |
This comment has been minimized.
This comment has been minimized.
|
It was about limiting expression query results originally, but then it seems further down people started misunderstanding it and adding their thoughts about the metrics list and autocomplete. That seems like a separate issue though, despite it being similar. |
jacksontj commentedOct 20, 2017
What did you do?
I have a cluster which returns ~150k names from
/api/v1/label/__name__/values. This takes a decent amount of time for the browser to load, but then when you go to type it is slow to the point of unusable. For me at least (in both chrome and firefox) after I finish typing 2 characters it immediately pegs a CPU core for ~2m or so, rending the browser useless.What did you expect to see?
I expect it to keep up :) A great example is from the grafana guys. They recently added ace editor support for promql (grafana/grafana#9118) and that javascript typeahead doesn't have problems with my 150k names