Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick one: gogo/protobuf/proto or golang/protobuf/proto #3346

Closed
tomwilkie opened this Issue Oct 24, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@tomwilkie
Copy link
Member

tomwilkie commented Oct 24, 2017

gogo/protobuf/proto seems to be a copy of golang/protobuf/proto. We should be consistent.

$ f 'gogo/protobuf/proto'
./documentation/examples/remote_storage/remote_storage_adapter/main.go:	"github.com/gogo/protobuf/proto"
./prompb/rpc.pb.go:import proto "github.com/gogo/protobuf/proto"
./prompb/types.pb.go:import proto "github.com/gogo/protobuf/proto"
./prompb/remote.pb.go:import proto "github.com/gogo/protobuf/proto"
./web/federate.go:	"github.com/gogo/protobuf/proto"
./web/api/v1/api_test.go:	"github.com/gogo/protobuf/proto"

$ f 'golang/protobuf/proto'
./documentation/examples/remote_storage/example_write_adapter/server.go:	"github.com/golang/protobuf/proto"
./prompb/rpc.pb.gw.go:	"github.com/golang/protobuf/proto"
./storage/remote/client.go:	"github.com/golang/protobuf/proto"
./storage/remote/codec.go:	"github.com/golang/protobuf/proto"
@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Oct 31, 2017

DIBS

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Nov 6, 2017

The only remaining references to golang/protobuf/proto are in vendored code.

@beorn7 beorn7 closed this Nov 6, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.