Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align columns in targets view #3373

Closed
caarlos0 opened this Issue Oct 30, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@caarlos0
Copy link

caarlos0 commented Oct 30, 2017

it's a minor, but the tables are not aligned (each column has a different width in each table)... it would look better if they all have the same size.

Image:

image

@biglovisa

This comment has been minimized.

Copy link
Contributor

biglovisa commented Nov 8, 2017

I'll take a look at this, shouldn't be too much work to fix.

@bwplotka

This comment has been minimized.

Copy link
Contributor

bwplotka commented Mar 15, 2018

Are we sure this is really better than what it was? I would rather have readable labels than aligned columns ):

Labels are wrapped terribly. The same is when label value/name is long enough to exceed fixed width.

image

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Mar 15, 2018

@Bplotka I tend to agree with you. Also a job that has errors needs vastly more space in the errors column than a job that doesn't have an error, and it would be nice to be able to use that unused space better in the error-free jobs (e.g. to have more space for labels and such).

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Mar 15, 2018

I see that ironically I was the person merging this change, but I didn't see that label wrapping problem back then. It'd be nice to at least improve that.

@bwplotka

This comment has been minimized.

Copy link
Contributor

bwplotka commented Mar 15, 2018

Yea, could see that there was no test against these cases (e.g in given animation in PR)

@bwplotka

This comment has been minimized.

Copy link
Contributor

bwplotka commented Mar 15, 2018

Moved to new issue: #3972

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.