Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate NOTICE #3399
Comments
beorn7
added
help wanted
kind/cleanup
labels
Nov 2, 2017
This comment has been minimized.
This comment has been minimized.
|
Should we consider dropping the NOTICE file? It's only required to include it if there is one, though it might be too late to remove it now. |
This comment has been minimized.
This comment has been minimized.
|
I searched for glog to find out whether it needs to be removed from the NOTICE file. I couldn't find any references of it in the code, but it exists in the vendor folder. Should the license reference stay or should it be removed? |
This comment has been minimized.
This comment has been minimized.
|
I'd love to get an authoritative answer from a license expert if it is legally possible to not have the NOTICE file in an Apache-licensed repository. |
This comment has been minimized.
This comment has been minimized.
|
According to http://www.apache.org/dev/licensing-howto.html :
I also asked on the Apache Jira. https://issues.apache.org/jira/browse/LEGAL-354 I'll let you know when I have the answer. |
This comment has been minimized.
This comment has been minimized.
|
By the way according to the same link http://www.apache.org/dev/licensing-howto.html for BSD and MIT/X11 licenses, you should add a pointer to the dependency's license within the distribution and a short note summarizing its licensing in your LICENSE file. Shall I open a separate issue for this? |
This comment has been minimized.
This comment has been minimized.
|
Personally, I would say it's most reasonable to state that 3rd party code is in the |
This comment has been minimized.
This comment has been minimized.
|
The answer from Apache (https://issues.apache.org/jira/browse/LEGAL-354): Short answer, yes you should keep the NOTICE file. Long answer:
|
This comment has been minimized.
This comment has been minimized.
|
Sounds like we need to keep it and keep it up to date at least for other Apache-licensed software we vendor. But I leave the final call to the maintainers of this repo: @brian-brazil @fabxc @juliusv |
This comment has been minimized.
This comment has been minimized.
|
Any executive decision on this from the maintainers? @brian-brazil @fabxc @juliusv From the above, it looks we are in breach of the Apache license if we don't keep the NOTICE file up to date. |
This comment has been minimized.
This comment has been minimized.
|
If our chosen license requires it, I guess no contrary opinions are really relevant – we have to do it. |
This comment has been minimized.
This comment has been minimized.
|
To me this isn't 100% clear-cut yet. We do need to distribute the original license notices somewhere, but according to my reading, not necessarily in a central NOTICE file. The relevant section 4.d. in https://www.apache.org/licenses/LICENSE-2.0.html#redistribution says:
...with the most relevant part being: "[...] in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works [...]" So if we just keep the upstream NOTICE files together with their upstream code (like we do in some cases, like Looking at Kubernetes, they probably have many more dependencies than we do, and no central NOTICE file. |
beorn7 commentedNov 2, 2017
The NOTICE file in the repository's root is a requirement of the Apache license.
The file hasn't been maintained for a while and contains many entries that don't apply anymore, while it is missing many other entries.
Since we vendor the license files, there is certainly nothing missing from the repo as a whole but we should update the NOTICE file at our next convenience.