staticcheck: kubernetes.go error SA1019 (1.8.2)

[knweiss]

What did you do?

go/src/github.com/prometheus/prometheus (release-1.8) $ git describe --tag
v1.8.2
go/src/github.com/prometheus/prometheus (release-1.8) $ make
>> formatting code
>> running staticcheck
discovery/kubernetes/kubernetes.go:162:13: d.client.Core is deprecated: please explicitly pick a version if possible.  (SA1019)
discovery/kubernetes/kubernetes.go:163:14: d.client.Extensions is deprecated: please explicitly pick a version if possible.  (SA1019)
make: *** [staticcheck] Error 1

What did you expect to see?

No staticcheck errors.

What did you see instead? Under which circumstances?

SA1019

Environment

$ go version                                                                                                                                                                                                                           
go version go1.9.2 linux/amd64
$ staticcheck -version
staticcheck (no version)

(it's the latest staticcheck version)

Workaround

$ git diff
diff --git a/Makefile b/Makefile
index 41317fcb..55dfaf05 100644
--- a/Makefile
+++ b/Makefile
@@ -28,6 +28,7 @@ endif

 STATICCHECK_IGNORE = \
   github.com/prometheus/prometheus/discovery/kubernetes/node.go:SA1019 \
+  github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:SA1019 \
   github.com/prometheus/prometheus/documentation/examples/remote_storage/remote_storage_adapter/main.go:SA1019 \
   github.com/prometheus/prometheus/storage/local/codable/codable.go:SA6002 \
   github.com/prometheus/prometheus/storage/local/persistence.go:SA6002 \

[grobie]

It is fixed in master already. I'm not sure there is much we can do for an already tagged version.

[brian-brazil]

We don't change tags once they're released so I don't think there's anything to do here.

[beorn7]

Note that the “fix” is to simply include the warning in STATICCHECK_IGNORE in the Makefile, i.e. exactly the workaround @knweiss mentioned. If you need to build the 1.8.2 tag yourself, patch in the same line.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.