Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIntegrations link broken #3537
Comments
This comment has been minimized.
This comment has been minimized.
|
@grobie Should we be using full URLs for things like this? |
This comment has been minimized.
This comment has been minimized.
|
Yes. Links to content on prometheus.io / prometheus/docs should be absolute URLs. All other links are assumed to reference pages/content inside of this repo. |
This comment has been minimized.
This comment has been minimized.
|
Hi there! I’m a first-time contributor and was hoping to help out with this issue. Is there documentation on how to build the static docs to verify that the change renders correctly on prometheus.io? |
This comment has been minimized.
This comment has been minimized.
|
@ameseee The README for the docs project has the instructions: |
This comment has been minimized.
This comment has been minimized.
|
Thanks @jamtur01 - I've gotten the doc site running locally, but the make file seems to have hard coded values for the prometheus github to curl content. My fork of the prometheus repo has the updated link in docs/configuration/configuration.md, but I cannot verify that it works due to the hard coded make file. Is there a way to adjust the make file so only the prometheus repo will get pulled from my fork, or would you like me to submit a PR for the changed link without verifying locally? |
This comment has been minimized.
This comment has been minimized.
|
For a simple thing like this, a PR with the fix is okay. nanoc.yaml is the file you need to tweak to have it pull in from other places. |
brian-brazil
closed this
in
#3551
Dec 6, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
jamtur01 commentedDec 2, 2017
On the Prometheus configuration page in the file discovery section:
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#file_sd_config
There's a link to integrations that resolves to:
https://github.com/prometheus/prometheus/blob/release-2.0/docs/operating/configuration/#%3Cfile_sd_config
It should resolve to:
https://prometheus.io/docs/operating/integrations/#file-service-discovery
In configuration.md it looks like it should be right.
There is a list of [integrations](/docs/operating/integrations/#file-service-discovery) with this discovery mechanism.Perhaps needs to be rebuilt?