Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrations link broken #3537

Closed
jamtur01 opened this Issue Dec 2, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@jamtur01
Copy link
Contributor

jamtur01 commented Dec 2, 2017

On the Prometheus configuration page in the file discovery section:

https://prometheus.io/docs/prometheus/latest/configuration/configuration/#file_sd_config

There's a link to integrations that resolves to:

https://github.com/prometheus/prometheus/blob/release-2.0/docs/operating/configuration/#%3Cfile_sd_config

It should resolve to:

https://prometheus.io/docs/operating/integrations/#file-service-discovery

In configuration.md it looks like it should be right.

There is a list of
[integrations](/docs/operating/integrations/#file-service-discovery) with this
discovery mechanism.

Perhaps needs to be rebuilt?

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Dec 2, 2017

@grobie Should we be using full URLs for things like this?

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Dec 4, 2017

Yes. Links to content on prometheus.io / prometheus/docs should be absolute URLs. All other links are assumed to reference pages/content inside of this repo.

@ameseee

This comment has been minimized.

Copy link
Contributor

ameseee commented Dec 5, 2017

Hi there! I’m a first-time contributor and was hoping to help out with this issue. Is there documentation on how to build the static docs to verify that the change renders correctly on prometheus.io?

@jamtur01

This comment has been minimized.

Copy link
Contributor Author

jamtur01 commented Dec 5, 2017

@ameseee The README for the docs project has the instructions:

https://github.com/prometheus/docs/blob/master/README.md

@ameseee

This comment has been minimized.

Copy link
Contributor

ameseee commented Dec 6, 2017

Thanks @jamtur01 - I've gotten the doc site running locally, but the make file seems to have hard coded values for the prometheus github to curl content. My fork of the prometheus repo has the updated link in docs/configuration/configuration.md, but I cannot verify that it works due to the hard coded make file. Is there a way to adjust the make file so only the prometheus repo will get pulled from my fork, or would you like me to submit a PR for the changed link without verifying locally?

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Dec 6, 2017

For a simple thing like this, a PR with the fix is okay. nanoc.yaml is the file you need to tweak to have it pull in from other places.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.