Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uppromtool command for dynamic retention #3628
Comments
This comment has been minimized.
This comment has been minimized.
|
I'm not a fan of having anything in promtool require a config file (bar
validation/unittests), I think it should work entirely via the command line.
Nor do I think that promtool should be a daemon, as that's not very tool
like.
In relation to the particular feature I'd suggest having users use Cron for
a good while so we can see how this works out in terms of operations and
support rather than adding it to the core immediately.
On 27 Dec 2017 11:15, "Goutham Veeramachaneni" <notifications@github.com> wrote:
This would be a simple tool that hits the right endpoints based on a simple
config-file that looks like this:
# The frequency at which tombstone cleanup needs to be run.# This
means the /clean_tombstones endpoint is hit every 1hcleanup_interval:
1h# The frequency at which the deletes need to be run.# This means
that the /delete_series endpoint is hit every 5mins for the below
deletes.delete_interval: 5m
deletes:
- queries:
- {__name__=~"job1_.*"}
- {job="tempJob"}
retention: 10h # The retention time of every series that matches
the above queries.
@brian-brazil <https://github.com/brian-brazil> Are you ok with including
this in promtool?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3628>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGyTdq2BVa_JoGusBbnXiPGlqTDnbXo0ks5tEibfgaJpZM4RNaJs>
.
|
simonpasquier
added
priority/Pmaybe
component/promtool
labels
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gouthamve commentedDec 27, 2017
This would be a simple tool that hits the right endpoints based on a simple config-file that looks like this:
@brian-brazil Are you ok with including this in promtool?