Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMove shared config types to the common repo #3643
Comments
This comment has been minimized.
This comment has been minimized.
|
IIUC everything's already present in common (see common/config/http_config.go). Or am I missing something? |
This comment has been minimized.
This comment has been minimized.
|
That has drifted a bit, so needs to be all brought up to date. Note that the blackbox exporter requires non-persistent connections. |
This comment has been minimized.
This comment has been minimized.
|
@shubheksha unless you plan to do it, I can give it a try. |
This comment has been minimized.
This comment has been minimized.
|
I would like to discuss an idea for the config handling in general. |
This comment has been minimized.
This comment has been minimized.
|
@simonpasquier Picking this up! |
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil, @simonpasquier is right. I compared the two files, everything is already present in |
This was referenced Jan 10, 2018
juliusv
closed this
in
#3674
Jan 11, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
shubheksha commentedJan 2, 2018
In PR #3629, we moved shared types to
util/configbut since they're used across the project we should moveSecret,TLSConfig,HTTPClientConfig, etc., to common.