Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shared config types to the common repo #3643

Closed
shubheksha opened this Issue Jan 2, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@shubheksha
Copy link
Contributor

shubheksha commented Jan 2, 2018

In PR #3629, we moved shared types to util/config but since they're used across the project we should move Secret, TLSConfig, HTTPClientConfig, etc., to common.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Jan 5, 2018

IIUC everything's already present in common (see common/config/http_config.go). Or am I missing something?

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jan 5, 2018

That has drifted a bit, so needs to be all brought up to date. Note that the blackbox exporter requires non-persistent connections.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Jan 10, 2018

@shubheksha unless you plan to do it, I can give it a try.

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Jan 10, 2018

I would like to discuss an idea for the config handling in general.
will ping you when the WIP PR is ready

@shubheksha

This comment has been minimized.

Copy link
Contributor Author

shubheksha commented Jan 10, 2018

@simonpasquier Picking this up!

@shubheksha

This comment has been minimized.

Copy link
Contributor Author

shubheksha commented Jan 10, 2018

@brian-brazil, @simonpasquier is right. I compared the two files, everything is already present in common. Only this repo needs to be switched over to use common.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.