Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor `TargetGroup` struct #3644

Open
shubheksha opened this Issue Jan 2, 2018 · 0 comments

Comments

Assignees
No one assigned
Labels
component/config component/service discovery kind/cleanup
Projects
None yet
Milestone
No milestone
2 participants
@shubheksha @simonpasquier
@shubheksha
Copy link
Contributor

shubheksha commented Jan 2, 2018

In PR #3629, we moved TargetGroup into its own package from config. However, we need to split this into two structs: one of them will resemble the YAML config and the other will be used for internal exchange between retrieval and discovery.

@simonpasquier simonpasquier added kind/cleanup component/config component/service discovery labels Aug 7, 2018

@simonpasquier simonpasquier referenced a pull request that will close this issue Nov 26, 2018

Open

discovery: remove manager's dependency on config #4913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.