Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove `config` dependency from `discovery` #3645
Comments
This comment has been minimized.
This comment has been minimized.
|
@krasi-georgiev, I believe you're working on something along these lines? |
This comment has been minimized.
This comment has been minimized.
|
yep , here is the first draft , but it is a WIP |
This comment has been minimized.
This comment has been minimized.
|
I was thinking of a global Config manager which is responsible for loading/parsing/providing the configs (thorugh Each package will use the Read interface and converts the input to the package internal config types so neither the config nor any other packages have to import shared structs types. |
This comment has been minimized.
This comment has been minimized.
|
Sounds good! /cc @juliusv |
simonpasquier
referenced this issue
Nov 26, 2018
Open
discovery: remove manager's dependency on config #4913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
shubheksha commentedJan 2, 2018
This is a follow-up to #3013. In #3629, we removed
configdependency from thediscoverypackage partially. We need to decouple these packages completely.