Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `config` dependency from `discovery` #3645

Open
shubheksha opened this Issue Jan 2, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@shubheksha
Copy link
Contributor

shubheksha commented Jan 2, 2018

This is a follow-up to #3013. In #3629, we removed config dependency from the discovery package partially. We need to decouple these packages completely.

@shubheksha

This comment has been minimized.

Copy link
Contributor Author

shubheksha commented Jan 2, 2018

@krasi-georgiev, I believe you're working on something along these lines?

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Jan 2, 2018

yep , here is the first draft , but it is a WIP
#3605

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Jan 2, 2018

I was thinking of a global Config manager which is responsible for loading/parsing/providing the configs (thorugh Read() struct{.....} interface)

Each package will use the Read interface and converts the input to the package internal config types so neither the config nor any other packages have to import shared structs types.

@shubheksha

This comment has been minimized.

Copy link
Contributor Author

shubheksha commented Jan 3, 2018

Sounds good! /cc @juliusv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.