Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we need 2 packages relabel packages? /pkg/relabel, /relabel #3647

Closed
krasi-georgiev opened this Issue Jan 2, 2018 · 4 comments

Comments

Assignees
No one assigned
Labels
help wanted kind/cleanup low hanging fruit priority/P3
Projects
None yet
Milestone
No milestone
4 participants
@krasi-georgiev @brian-brazil @vn-ki @codesome
@krasi-georgiev
Copy link
Member

krasi-georgiev commented Jan 2, 2018 •
edited

Wondering what is the reason to have 2 almost identical relabel packages and if we can combine it into one.
/pkg/relabel
/relabel

or rename to avoid the confusion if they serve different purpose.
@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member

brian-brazil commented Jan 2, 2018

Only the pkg one is meant to be there in 2.0

@brian-brazil brian-brazil added kind/cleanup priority/P3 labels Jan 2, 2018

@krasi-georgiev

This comment has been minimized.

Sign in to view
Copy link
Member Author

krasi-georgiev commented Jan 2, 2018 •
edited

will wait for some conflicting PRs to be merged and will cleanup

@krasi-georgiev krasi-georgiev referenced this issue Feb 10, 2018

Closed

merge pkg/relabel and relabel #3819

@krasi-georgiev krasi-georgiev referenced this issue Feb 19, 2018

Closed

prometheus - Unify the testing across all packages. #38

@sipian sipian referenced this issue Apr 13, 2018

Closed

merge relabel into pkg/relabel #4083

@krasi-georgiev krasi-georgiev added help wanted low hanging fruit labels Nov 28, 2018

bwplotka added a commit to bwplotka/prometheus that referenced this issue Dec 4, 2018

@bwplotka
Removed config dependency from `relabel` package. 
Adapted top dir relabel to use pkg relabel structs.

Removal of this in a separate tracked here: prometheus#3647

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
68b5572

@bwplotka bwplotka referenced this issue Dec 4, 2018

Merged

Removed config dependency from `relabel` package. #4955

brian-brazil added a commit that referenced this issue Dec 18, 2018

@bwplotka @brian-brazil
Moved configuration into `relabel` package. (#4955) 
Adapted top dir relabel to use pkg relabel structs.

Removal of this in a separate tracked here: #3647

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Loading status checks…
62c8337
@vn-ki

This comment has been minimized.

Sign in to view
Copy link
Contributor

vn-ki commented Dec 31, 2018

Is this issue done?
@codesome

This comment has been minimized.

Sign in to view
Copy link
Member

codesome commented Jan 1, 2019

No, it is being done in this PR #4083

tomwilkie added a commit to grafana/prometheus that referenced this issue Mar 11, 2019

@tomwilkie
Remove old relabel pkg (part of prometheus#3647). 
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
1c63764

tomwilkie added a commit to grafana/prometheus that referenced this issue Mar 12, 2019

@tomwilkie
Use pkg/relabelling in remote write. 
- Unmarshall external_labels config as labels.Labels, add tests.
- Convert some more uses of model.LabelSet to labels.Labels.
- Remove old relabel pkg (fixes prometheus#3647).
- Validate external label names.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
f87ecec

tomwilkie added a commit to grafana/prometheus that referenced this issue Mar 13, 2019

@tomwilkie
Use pkg/relabelling in remote write. 
- Unmarshall external_labels config as labels.Labels, add tests.
- Convert some more uses of model.LabelSet to labels.Labels.
- Remove old relabel pkg (fixes prometheus#3647).
- Validate external label names.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
8b4f5b3

@tomwilkie tomwilkie closed this in c7b3535 Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.