Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_sd sends all target groups down updates channel #3699

Closed
cstyan opened this Issue Jan 18, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@cstyan
Copy link
Contributor

cstyan commented Jan 18, 2018

SD implementations are only supposed to send changed target groups down the channel when sending updates, but file_sd sends all target groups when only one has changed.

relates to #1406

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jan 18, 2018

I don't see this a bug, it's a design decision by file_sd and the SD code should be able to handle it.

@cstyan

This comment has been minimized.

Copy link
Contributor Author

cstyan commented Jan 18, 2018

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jan 18, 2018

There's nothing saying an SD can't send everything subsequently, and for some SDs that's easier.

@cstyan

This comment has been minimized.

Copy link
Contributor Author

cstyan commented Jan 18, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.