recording rules omit without clause

[intenseFrog]

What did you do?

We defined some recording rules to speed up our dashboard

What did you expect to see?

Rules should be reflected as defined

groups:
  - name: container
    rules:
    - record: container:mem:sum
      expr: container_memory_usage_bytes
  - name: pod
    rules:
    - record: pod:mem:sum
      expr: sum without()(container:mem:sum{pod_name=~".+"})

What did you see instead? Under which circumstances?

without clause in the second rule was omitted

Environment

• System information:

  4.4.111-boot2docker

• Prometheus version:

  prometheus, version 2.0.0 (branch: HEAD, revision: 0a74f98628a0463dddc90528220c94de5032d1a0) build user: root@615b82cb36b6 build date: 20171108-07:11:59 go version: go1.9.2

• Prometheus configuration file:
  Will provide them if necessary.

• Logs:
  Will provide them if necessary.

[krasi-georgiev]

had a quick look and it uses the promql parser so doesn't look like an easy fix without changes to the promql package.
will keep digging.

[krasi-georgiev]

@intenseFrog btw why do you need to have an empty without()?

sum without()(container:mem:sum{pod_name=~".+"})
isn't this the same as
container:mem:sum{pod_name=~".+"}

[juliusv]

Thanks! Fix was easy and is in #3719

[krasi-georgiev]

@juliusv I was thinking about this fix as well but than the 'by()' is still not covered.

[juliusv]

@krasi-georgiev Omitting an empty by() clause is equivalent to having that empty clause, so I think that's fine?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.