Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle runs tests on PR rather than the merge #3708

Closed
gouthamve opened this Issue Jan 19, 2018 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gouthamve @simonpasquier
@gouthamve
Copy link
Member

gouthamve commented Jan 19, 2018

Travis runs the tests on the merged code:

$ git fetch origin +refs/pull/3700/merge:
remote: Counting objects: 5, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 5 (delta 3), reused 2 (delta 1), pack-reused 0
Unpacking objects: 100% (5/5), done.
From https://github.com/prometheus/prometheus
 * branch            refs/pull/3700/merge -> FETCH_HEAD
$ git checkout -qf FETCH_HEAD

While Circle runs on the PR code itself. Is this intentional?
@simonpasquier

This comment has been minimized.

Sign in to view
Copy link
Member

simonpasquier commented Sep 4, 2018

@gouthamve can we close this? I don't see that it's relevant as of today.
@simonpasquier

This comment has been minimized.

Sign in to view
Copy link
Member

simonpasquier commented Sep 6, 2018

Closing for now.

@simonpasquier simonpasquier closed this Sep 6, 2018

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.