Autocomplete on expression inputs is overzealous

[juliusv]

See:

When I type that expression and just press "Return", it will now select a completely unrelated historical expression and execute that instead. It's now quite hard to just query what you want to query when having "Search query history" enabled.

This should be smarter / more restrictive in the matching of history items, and/or it should not auto-select the first completion item, but rather whatever the user has typed (which would require the user to press DownArrow to select the first completion item instead).

[juliusv]

/cc @lovisas

[biglovisa]

Not auto selecting the first completion item is something that definitively should be fixed. I'll take a go at making the matching against historical expressions smarter as well.

[juliusv]

@lovisas Awesome, thanks!

[biglovisa]

Let me know if this is blocking anyone/anything and I'll split up the work in two smaller PRs to get it through quicker!

[juliusv]

@lovisas I guess it'd be good to have something in the next release, but since 2.1.0 just happened, that's probably still quite a ways off.

[beorn7]

We could consider the current behavior a bug (even a regression as we had the same problem before and then reverted the advanced autocompletion) and then release a fix in 2.1.1.
Or we could just release 2.2 quite soon. As discussed earlier, we are not shy releasing frequently if it delivers some value.

[juliusv]

Yeah, I did mark this issue as a bug and consider it one (that really impacts Prometheus use), so doing a 2.1.1 soon would be a good idea.

[paddynewman]

+1 for a 2.1.1 release soon.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.