Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better syntax mistake errors #372

Closed
typingduck opened this Issue Nov 11, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@typingduck
Copy link

typingduck commented Nov 11, 2013

Currently syntax errors in the UI are of the form "Error parsing rules at line 1, char 6: syntax error" when the 5th character is incorrect.
The off-by-one error plus not reporting which character is the problem makes it difficult to diagnose.
(As a side not the problem character here was the '.' char. Not sure if this is explicitly disallowed or not. If disallowed then perhaps it should be filtered out at an earlier stage)

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Apr 18, 2014

To cover more syntax error cases with custom error messages, we'd need to move away from Lex&Yacc and build our own parser from scratch. That's not likely to happen soon, so unfortunately we'll be stuck with the current level of error reporting for the time being.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 7, 2015

Fixed by #676

@fabxc fabxc closed this May 7, 2015

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

Merge pull request prometheus#372 from prometheus/google-search-resul…
…t-improvements

Improve search engine result presentation

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.