Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the Dockerfile on Dockerhub for the Prometheus image #3778

Open
CharlesWinter opened this Issue Feb 1, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@CharlesWinter
Copy link

CharlesWinter commented Feb 1, 2018

Just a quick note to please update the Dockerfile example shown on Dockerhub to reflect the new command line arguments that are required.

@kaytrance

This comment has been minimized.

Copy link

kaytrance commented Feb 15, 2018

Can you specify them? I cannot launch prometheus docker image

@CharlesWinter

This comment has been minimized.

Copy link
Author

CharlesWinter commented Feb 15, 2018

@kaytrance Because the flags to Prometheus have changed in the latest version, I had to use the following CMD in my Dockerfile to get prometheus v2.1.0 to run.

CMD        [ "--config.file=/etc/prometheus/prometheus.yml", \
             "--storage.tsdb.path=/prometheus", \
             "--web.console.libraries=/etc/prometheus/console_libraries", \
             "--web.console.templates=/etc/prometheus/consoles", \
             "--web.external-url=https://YOURDOMAIN/prometheus", \
             "--web.route-prefix=/prometheus" ]
@hairyhenderson

This comment has been minimized.

Copy link
Contributor

hairyhenderson commented Mar 25, 2018

If it's https://hub.docker.com/r/prom/prometheus/~/dockerfile/ you're talking about, that's not an example, that's the Dockerfile used for the automated build. Unfortunately it looks like the last time an automated build was run was ~2yrs ago (see https://hub.docker.com/r/prom/prometheus/builds/).

Since then, it appears that docker images have been pushed as part of the CircleCI build. So it's not really an automated build...

I don't think there's a way to alter the listed Dockerfile manually in DockerHub - to update it must be run automatically again.

@kristaxox

This comment has been minimized.

Copy link

kristaxox commented Oct 9, 2018

Would love to fix this if there were a way to post the Dockerfile to the Docker Hub on a Circle CI build.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Oct 10, 2018

@kristaxox I'd rather remove the Dockerfile from Docker Hub as it is easy to get it from GitHub. I'm trying to get that done btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.