Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove old PromQL artifacts #3818
Comments
brancz
added
kind/cleanup
component/rules
component/promql
labels
Feb 10, 2018
brian-brazil
added
low hanging fruit
priority/P3
labels
Feb 10, 2018
brancz
referenced this issue
Feb 14, 2018
Merged
promql: Remove old and unused alerting/reconding syntax #3839
brancz
closed this
in
#3839
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
brancz commentedFeb 10, 2018
I was reading through PromQL parser/lexer code and realized there are old and unused artifacts in the lexer/parser from the old (pre 2.0) recording and alerting rule format.
For example:
prometheus/promql/lex.go
Lines 221 to 225 in dfdd2cb
This should also simplify the lexer/parser, as only expressions will be left to parse.