Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old PromQL artifacts #3818

Closed
brancz opened this Issue Feb 10, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@brancz
Copy link
Member

brancz commented Feb 10, 2018

I was reading through PromQL parser/lexer code and realized there are old and unused artifacts in the lexer/parser from the old (pre 2.0) recording and alerting rule format.

For example:

prometheus/promql/lex.go

Lines 221 to 225 in dfdd2cb

"alert": itemAlert,
"if": itemIf,
"for": itemFor,
"labels": itemLabels,
"annotations": itemAnnotations,

This should also simplify the lexer/parser, as only expressions will be left to parse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.