Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bool modifier should remove metric name #3820

Closed
brian-brazil opened this Issue Feb 10, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
component/promql kind/bug low hanging fruit priority/P3
Projects
None yet
Milestone
No milestone
2 participants
@brian-brazil @krasi-georgiev
@brian-brazil
Copy link
Member

brian-brazil commented Feb 10, 2018

The bool modifier changes the value of the metric, and thus in line with everywhere else in PromQL should be removing the metric name.

@brian-brazil brian-brazil added low hanging fruit kind/bug component/promql priority/P3 labels Feb 10, 2018

@krasi-georgiev

This comment has been minimized.

Sign in to view
Copy link
Member

krasi-georgiev commented Feb 10, 2018

DIBS again :)

@krasi-georgiev krasi-georgiev referenced this issue Feb 11, 2018

Merged

Drop metric name for bool modifier #3821

krasi-georgiev added a commit to krasi-georgiev/prometheus that referenced this issue Feb 11, 2018

@krasi-georgiev
drop metric name for bool modifier 
fixes prometheus#3820
64a8ddc

@brian-brazil brian-brazil closed this in #3821 Feb 11, 2018

brian-brazil added a commit that referenced this issue Feb 11, 2018

@krasi-georgiev @brian-brazil
drop metric name for bool modifier (#3821) 
fixes #3820
Loading status checks…
a53d4ed

brian-brazil added a commit that referenced this issue Feb 11, 2018

@brian-brazil
Fix docs for #3820
Loading status checks…
786397b

brian-brazil added a commit that referenced this issue Feb 11, 2018

@brian-brazil
Fix docs for #3820 (#3823)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
66b8bdb
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.