Switch from InstrumentHandler to InstrumentHandlerDuration

[brian-brazil]

The current InstrumentHandler we are using in web.go is deprecated, we should replace it with InstrumentRoundTripperDuration.

[beorn7]

InstrumentRoundTripper… is for client-side instrumentation. To replace InstrumentHandler from the prometheus package, you want to use the InstrumentHandler… family of middlewares from the promhttp package.

[brian-brazil]

Thanks, summary updated.

[simonpasquier]

@brian-brazil I'm willing to tackle this one. Since you mention only the InstrumentHandlerDuration handler, does it mean that http_request_size_* and http_requests_total metrics should be dropped?

[brian-brazil]

The duration will include the request count. I'm not sure if we want size, probably doesn't hurt.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.