Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCan't add GZ zone discovery end points #3871
Comments
This comment has been minimized.
This comment has been minimized.
|
Another dirty fix can be changing the version type to string :) but it's a bad idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Adel-Magebinary commentedFeb 20, 2018
•
edited
Hello @richardkiene
Since the endpoint is consist of Endpoint, Port, Version.
Could you please add a Zone as a config as well?
var endpoint = fmt.Sprintf("https://%s:%d/v%d/discover", d.sdConfig.Endpoint, d.sdConfig.Port, d.sdConfig.Version)becomes
var endpoint = fmt.Sprintf("https://%s:%d/v%d/%s/discover", d.sdConfig.Endpoint, d.sdConfig.Port, d.sdConfig.Version,d.sdConfig.Zone)where d.sdConfig.Zone can be 'gz'
eg:
"https://cmon.cns.x.com:9163/v1/gz/discover"
Related code:
prometheus/discovery/triton/triton.go
Line 193 in 675ce53