Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add GZ zone discovery end points #3871

Open
Adel-Magebinary opened this Issue Feb 20, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Adel-Magebinary
Copy link

Adel-Magebinary commented Feb 20, 2018

Hello @richardkiene

Since the endpoint is consist of Endpoint, Port, Version.

Could you please add a Zone as a config as well?

var endpoint = fmt.Sprintf("https://%s:%d/v%d/discover", d.sdConfig.Endpoint, d.sdConfig.Port, d.sdConfig.Version)

becomes

var endpoint = fmt.Sprintf("https://%s:%d/v%d/%s/discover", d.sdConfig.Endpoint, d.sdConfig.Port, d.sdConfig.Version,d.sdConfig.Zone)

where d.sdConfig.Zone can be 'gz'
eg:
"https://cmon.cns.x.com:9163/v1/gz/discover"

Related code:

var endpoint = fmt.Sprintf("https://%s:%d/v%d/discover", d.sdConfig.Endpoint, d.sdConfig.Port, d.sdConfig.Version)

@Adel-Magebinary

This comment has been minimized.

Copy link
Author

Adel-Magebinary commented Feb 20, 2018

Another dirty fix can be changing the version type to string :) but it's a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.