Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate annotations in ALERTS metric #3898

Closed
MorphBonehunter opened this Issue Mar 1, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@MorphBonehunter
Copy link

MorphBonehunter commented Mar 1, 2018

For using the (templated) annotations from the alert rules in external Tools like Grafana it would be nice if the annotations are exporter not only to the alertmanager but are also accessible in the ALERTS Metric.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Mar 1, 2018

This wouldn't work out, as annotations can vary from evaluation to evaluation so it'd cause cardinality issues. Annotations can only exist for long enough to send them to the alertmanager.

@MorphBonehunter

This comment has been minimized.

Copy link
Author

MorphBonehunter commented Mar 1, 2018

Ok, i understand that. Maybe it make sense to still think about it for using the annotations outside the alertmanager. So at the moment the annotations are only usable outside prometheus and i would think it should be possible to use all "output" that prometheus produces als use inside prometheus (could be an wrong sight).
So maybe the ALERS Metric could be split to some smaler parts (maybe alert Group, or if this makes sense to per Rule) and include then the annotations?

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Mar 1, 2018

It doesn't make sense to have the annotations inside the tsdb at all, as they are event logging rather than metrics.

@MorphBonehunter

This comment has been minimized.

Copy link
Author

MorphBonehunter commented Mar 1, 2018

But labels do? 😄
Whats the difference in this case? Don't get me wrong, but the annotations are something like the labels in this case.
So if this makes no sense, you can close this issue. I just thougt it might be an good idea...maybe i'm wrong 😁

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Mar 1, 2018

Labels are the identify of an alert, if they're varying from evaluation to evaluation you have a problem.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.