Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upReuse the same Makefile across projects #3904
Comments
brian-brazil
added
kind/cleanup
priority/P3
labels
Mar 3, 2018
This was referenced Mar 18, 2018
krasi-georgiev
closed this
in
#3978
Apr 19, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
krasi-georgiev commentedMar 2, 2018
Most projects will benefit from reusing a big part of the current prometheus Makefile.
Many are already sharing 90% , but slowly starting to drift.
The idea is to keep the prometheus Makefile as the main source so any PR would be opened against that and all other projects will simply copy the prometheus Makefile.
Any differences should be able to tackle using the makefile include directive to include any custom targets and env variable for each repo.