Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upOptional Filter for EC2 Discovery #3920
Comments
cnicolov
referenced this issue
Mar 25, 2018
Merged
discovery/ec2: Support filtering instances in discovery #4011
brian-brazil
closed this
in
#4011
Mar 31, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Zordrak commentedMar 7, 2018
I would really like to see an optional filter for AWS EC2 Discovery.
Currently, prometheus describes all instances, and then filters the results locally. In an AWS account with hundreds or thousands of instances, many of which are not related to prometheus' monitoring configuration, the amount of data requested and returned from the API is unnecessarily huge and time-consuming.
I would like to able to provide a custom filter string to be used with the DescribeInstances API call, so that the API only returns relevant instances for further processing.
Here's a really really bad example, but an example nonetheless of something we have done to patch in the functionality. We should not have done it in this hardcoded, and environment-variable-dependent manner, but it works for now: