Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CircleCI to V2 #3932

Closed
tylerauerbeck opened this Issue Mar 8, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@tylerauerbeck
Copy link

tylerauerbeck commented Mar 8, 2018

The current version of config that Prometheus uses for CircleCI (V1) is being deprecated.

https://circleci.com/blog/sunsetting-1-0/

We should migrate this to use the V2 config prior to the deprecation date.

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Mar 8, 2018

yep , that is a good idea. Can you open a PR?

here is the commit that was done for the node_exporter , probably can do a lot of copy and paste form there.
prometheus/node_exporter@65e485c

@tylerauerbeck

This comment has been minimized.

Copy link
Author

tylerauerbeck commented Mar 8, 2018

Yepp, no problem. I should have some time over the day or so to get something pulled together.

@sdurrheimer

This comment has been minimized.

Copy link
Member

sdurrheimer commented Mar 8, 2018

Some work are being done on CircleCI v2 on the node_exporter project. When they will be stabilized, we will do the move on all Prometheus projects.

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Mar 8, 2018

@sdurrheimer are you saying that it is best to wait until the one done in node_exporter is stable?

@sdurrheimer

This comment has been minimized.

Copy link
Member

sdurrheimer commented Mar 8, 2018

@krasi-georgiev It's probably better yes.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Aug 7, 2018

Fixed by #4106

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.