Magic number in the code

[zjwzte]

I find a magic number 163 here:

prometheus/scrape/scrape.go

Line 151 in ef567ce

buffers := pool.New(163, 100e6, 3, func(sz int) interface{} { return make([]byte, 0, sz) })

@fabxc I notice that you wrote the original code. Could you please explain a bit about this number? I guess 163 might be a typo and it should be 1e3. If so, I'd like to sent a patch to fix it :)

[fabxc]

Yea, that's a typo and was supposed to be 1e3 similar to the second argument.

[zjwzte]

@fabxc thanks for confirmation! PR #3968 sent :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.