Use UnmarshalStrict for yaml Unmarshalling

[krasi-georgiev]

The yaml library we are using now support UnmarshalStrict which will return an error for for unknowns, or double definitions
https://godoc.org/gopkg.in/yaml.v2#UnmarshalStrict

After start using UnmarshalStrict CheckOverflow will be no longer needer

prometheus/util/yaml/yaml.go

Lines 22 to 31 in dfd6709

	func CheckOverflow(m map[string]interface{}, ctx string) error {
	if len(m) > 0 {
	var keys []string
	for k := range m {
	keys = append(keys, k)
	}
	return fmt.Errorf("unknown fields in %s: %s", ctx, strings.Join(keys, ", "))
	}
	return nil
	}

[RichiH]

Related to #1275 and as per IRC, @fabxc said: "I still think we should be using https://github.com/ghodss/yaml "

[krasi-georgiev]

so basically if the other devs agree, replace gopkg.in/yaml with ghodss/yaml or just add PR to use UnmarshalStrict

[grobie]

Does ghodss/yaml handle YAML anchors?

…

On Tue, Mar 27, 2018 at 1:34 PM Krasi Georgiev ***@***.***> wrote: so basically if the other devs agree, replace gopkg.in/yaml with ghodss/yaml or just add PR to use UnmarshalStrict — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4017 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAANaC_fZRqY8Qy-BQsjqScpOp7xrErQks5tiiOtgaJpZM4S8vs_> .

[fabxc]

It uses the same YAML library but just performs a conversion to JSON, which is then parsed through the much saner encoding/json. On Tue, Mar 27, 2018 at 1:43 PM Tobias Schmidt <notifications@github.com> wrote:

…

Does ghodss/yaml handle YAML anchors? On Tue, Mar 27, 2018 at 1:34 PM Krasi Georgiev ***@***.***> wrote: > so basically if the other devs agree, replace gopkg.in/yaml with > ghodss/yaml or just add PR to use UnmarshalStrict > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > < #4017 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAANaC_fZRqY8Qy-BQsjqScpOp7xrErQks5tiiOtgaJpZM4S8vs_ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4017 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEuA8uyp0MSzgWjV2kFLGvnAe9cY4pk9ks5tiiXxgaJpZM4S8vs_> .

[brian-brazil]

I still fail to see the benefits of switching the data to a format that's not the one we're trying to parse.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.