Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avg() doesn't deal with NaN's #4023

Closed
zemek opened this Issue Mar 28, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@zemek
Copy link
Contributor

zemek commented Mar 28, 2018

If you try to run avg(query) on a query that returns some NaN values, the entire avg is NaN.

It seems like it would be reasonable to just exclude these NaNs from the average so you don't have to do like avg(query >= 0) or something more complicated if you want both positive/negative numbers.

@zemek

This comment has been minimized.

Copy link
Contributor Author

zemek commented Mar 28, 2018

and if you wanted to create an alert if query has NaN values, you would need to write a separate alert anyway like query != query

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Mar 28, 2018

This is the correct behaviour. You are most likely aggregating incorrectly and trying to take an average of an average, which is statistically invalid.

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.