Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue time component of query duration is not exposed #4049

Closed
roganartu opened this Issue Apr 5, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@roganartu
Copy link
Contributor

roganartu commented Apr 5, 2018

The queue time for a query is calculated and included in the total query time in query_stats, but there is no slice="queue_time" label in the query_duration_seconds metric where everything else from query_stats is exposed.

I looked at promql/engine.go history but couldn't see anywhere it was explicitly removed, so I can only figure it was an oversight.

In any case it was trivial to add, so I'll have a PR for it shortly.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.