Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul service discovery across all datacenters #4070

Closed
sev3ryn opened this Issue Apr 10, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@sev3ryn
Copy link
Contributor

sev3ryn commented Apr 10, 2018

Feature request:

Right now you have to add multiple scrappers with consul service discovery if you have more than one Consul datacenters(one scrapper per one DC).
I suggest to add ability to autodiscover Consul datacenters and aferwards to discover services to be scrapped for each DC.

I'm happy to implement this but first I want to know your opinion on following questions:

  1. Does this feature request not contradict Prometheus philosophy?
  2. Right now if consul_sd_configs.datacenter field is omitted - it uses local Consul DC. I suggest not to conflict with this functionality and add additional field dc_discovery:(true|false). Your thoughts?
    @brian-brazil @iksaif
@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Apr 10, 2018

The Prometheus design is that you would have one Prometheus per failure domain/datacenter, so it doesn't make sense to scrape all services in all datacenters. If you need this you can always list your datacenters in the config file.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.