Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic_auth_password_file to HTTP client config #4076

Closed
adamdecaf opened this Issue Apr 10, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adamdecaf @brian-brazil
@adamdecaf
Copy link
Contributor

adamdecaf commented Apr 10, 2018

As fallout from #4074 and #3090 I wanted a basic_auth_password_file option on an http client. This helps to keep the HTTP basic auth password out of display and logs.

I went ahead and filed prometheus/common#129, but noticed in testing that prometheus uses a slightly modified version.
@adamdecaf

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

adamdecaf commented Apr 10, 2018

I've coded up the modified form and verified it works. Should I PR just the change to prometheus? It still requires adding BasicAuthPasswordFile to config_util. HTTPClientConfig

@adamdecaf adamdecaf referenced this issue Apr 10, 2018

Merged

support HTTP basic_auth.password_file #129

@adamdecaf adamdecaf referenced this issue Apr 10, 2018

Merged

support reading basic_auth_password_file for HTTP basic auth #4077

adamdecaf added a commit to adamdecaf/prometheus that referenced this issue Apr 25, 2018

@adamdecaf
support reading basic_auth password_file for HTTP basic auth 
Issue: prometheus#4076

Signed-off-by: Adam Shannon <adamkshannon@gmail.com>
1cfa098

brian-brazil added a commit that referenced this issue Apr 25, 2018

@adamdecaf @brian-brazil
support reading basic_auth password_file for HTTP basic auth (#4077) 
Issue: #4076

Signed-off-by: Adam Shannon <adamkshannon@gmail.com>
Loading status checks…
809881d

@brian-brazil brian-brazil closed this May 5, 2018

gouthamve added a commit to gouthamve/prometheus that referenced this issue Aug 1, 2018

@adamdecaf @gouthamve
support reading basic_auth password_file for HTTP basic auth (prometh… 
…eus#4077)

Issue: prometheus#4076

Signed-off-by: Adam Shannon <adamkshannon@gmail.com>
eb3ce63
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.