Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus 2.2.1 /graph page doesn't work with Internet Explorer 11 #4098

Closed
adamc99 opened this Issue Apr 18, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@adamc99
Copy link

adamc99 commented Apr 18, 2018

What did you do?
Load the main /graph page with Internet Explorer 11.

What did you expect to see?
I expected it to load successfully and allow normal functionality, like with Chrome.

What did you see instead? Under which circumstances?
The page partially loads but doesn't include elements like the query text box, execute button and data tables/graphs.

With the IE developer tools open, the error
"SCRIPT1003: Expected ':'
File: index.js, Line: 265, Column:11"
appears in the console tab.

This seems to refer to the line

    source,

in the context of:

Prometheus.Graph.prototype.initTypeahead = function(self) {
  const source = queryHistory.isEnabled() ? pageConfig.queryHistMetrics.concat(pageConfig.allMetrics) : pageConfig.allMetrics;
  self.expr.typeahead({
    autoSelect: false,
    source,
    items: "all",

This occurs every time, tested from many machines and against multiple server instances (2.2.1 and built from master as of 18th Apr 2018).

As an attempt to investigate the issue, I manually compiled a version (based off of master as of 18th Apr 2018) with the line

    source,

changed to

    source: source,

and this seems to correct the issue: the page loads and basic functionality like querying for data and drawing graphs appear to work in both IE 11 and Chrome.

Prometheus version:

prometheus, version 2.2.1 (branch: HEAD, revision: bc6058c)
build user: root@149e5b3f0829
build date: 20180314-14:15:45
go version: go1.10

@bege13mot

This comment has been minimized.

Copy link
Contributor

bege13mot commented May 7, 2018

Hi,

Hope my pull request will be helpful.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.