Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExpose GCE labels during service discovery #4137
Comments
This comment has been minimized.
This comment has been minimized.
|
Would you like to send a PR? We generally accept all potentially useful metadata. |
brian-brazil
added
the
component/service discovery
label
May 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Open to creating a PR, but having some dependency issues. My local vendor files don't have the Instance.Labels parameter in the docs. It looks like the Google Compute dependencies that get imported don't match the docs here: https://godoc.org/google.golang.org/api/compute/v1 |
This comment has been minimized.
This comment has been minimized.
|
It sounds like you'll need to update the vendoring. We use govendor for this, |
This comment has been minimized.
This comment has been minimized.
|
Opened a PR for this. First time using Go, any feedback is appreciated. I was able to compile, run tests, and confirm that GCE labels were working on my end. |
woolite64
closed this
May 12, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
woolite64 commentedMay 3, 2018
•
edited
Proposal
Expose GCE instance labels as __meta_gce_label_ so that values can be passed to Target Labels.
It's currently possible to filter by GCE labels using Prometheus, but the values aren't available once the host is found. Tags and metadata are exposed (here) with __meta prefixes.