Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST API for SD. #4228

Closed
shunliz opened this Issue Jun 6, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@shunliz
Copy link

shunliz commented Jun 6, 2018

Proposal

Use case. Why is this important?
As a third-party system, i need register/deregister my endpoint to prometheus by REST API and be scraped. I don't like existing SDs as they are not flexible.

Not sure if it's a good idea, any suggestion?

Nice to have' is not a good use case :)

@jojohappy

This comment has been minimized.

Copy link
Contributor

jojohappy commented Jun 6, 2018

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 6, 2018

We don't want to invent new SDs in Prometheus (there's enough in the world already), and what you would suggest would do so and not work in a HA setup. If Consul isn't to your tastes (which is what we'd usually suggest here), I'd suggest using file_sd to build something.

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Jun 6, 2018

one big disadvantage in your proposal is that all your targets need to know the ip of the Prometheus server which might work in a small setup,but a big disadvantage at scale.

Can you share more details about your setup?

@shunliz

This comment has been minimized.

Copy link
Author

shunliz commented Jun 7, 2018

Thanks jojohappy, brian-brazil. Using the custom-sd is way to solve my problem, but I have many vms or docker created dynamically, and each time a vm or docker created, need to restart prometheus. I'm not sure if it will lose some metrics and if there is any problems that restart prometheus frequently.

Thanks krasi-georgiev. I just have a hybrid cloud controller which will need to monitor the vms or dockers created by the hybrid cloud controller in different cloud resource provider.

@jojohappy

This comment has been minimized.

Copy link
Contributor

jojohappy commented Jun 7, 2018

Prometheus has provide api to reload configuration, It will not need to restart Prometheus and impact on scrape process.

@shunliz

This comment has been minimized.

Copy link
Author

shunliz commented Jun 8, 2018

Thansk all for the comments and replys.
I think i can close this question.

@shunliz shunliz closed this Jun 8, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.