Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.0 # Optional namespace discovery, only picking up the last namespace in yaml array. #4269

Closed
Misterhex opened this Issue Jun 14, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@Misterhex
Copy link

Misterhex commented Jun 14, 2018

Bug Report

Upgraded from 2.2.1 to 2.3.0

What did you expect to see?
Optional namespace discovery still continue to pick up all namespaces provided.

What did you see instead? Under which circumstances?
Optional namespace discovery only seems to pick up the last namespace in namespace arrays.

- job_name: 'kubernetes-service-endpoints'
  kubernetes_sd_configs:
  - role: endpoints
    namespaces:
      names:
      - monitoring
      - logging

Environment
Prometheus v2.3.0

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 14, 2018

To be clear, you're saying that you're not getting any endpoints from the "monitoring" namespace?

@Misterhex

This comment has been minimized.

Copy link
Author

Misterhex commented Jun 14, 2018

@brian-brazil yes. no endpoints from monitoring, same configuration work for 2.2.1 but did not work in 2.3.1.

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Jun 14, 2018

@Misterhex could you share the whole config as well as the logs of the instance?

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Jun 14, 2018

I did a quick test and I happen to reproduce the issue :-/
I'll look into it...

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Jun 14, 2018

I've got a fix, just need to write some tests.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.