Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up2.3.0 # Optional namespace discovery, only picking up the last namespace in yaml array. #4269
Comments
This comment has been minimized.
This comment has been minimized.
|
To be clear, you're saying that you're not getting any endpoints from the "monitoring" namespace? |
brian-brazil
added
kind/bug
component/service discovery
labels
Jun 14, 2018
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil yes. no endpoints from monitoring, same configuration work for 2.2.1 but did not work in 2.3.1. |
This comment has been minimized.
This comment has been minimized.
|
@Misterhex could you share the whole config as well as the logs of the instance? |
This comment has been minimized.
This comment has been minimized.
|
I did a quick test and I happen to reproduce the issue :-/ |
This comment has been minimized.
This comment has been minimized.
|
I've got a fix, just need to write some tests. |
simonpasquier
referenced this issue
Jun 14, 2018
Merged
kubernetes_sd: fix namespace filtering #4273
brian-brazil
closed this
Jun 15, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Misterhex commentedJun 14, 2018
Bug Report
Upgraded from 2.2.1 to 2.3.0
What did you expect to see?
Optional namespace discovery still continue to pick up all namespaces provided.
What did you see instead? Under which circumstances?
Optional namespace discovery only seems to pick up the last namespace in namespace arrays.
Environment
Prometheus v2.3.0