Failing gofmt tests

[krasi-georgiev]

@brancz , @SuperQ do you remember why we run make test against .1.10 and 1.x?

It seems that we always update the second target (currently 1.10.x) to latest stable anyway so we are running against the same versions on both targets most of the time.

There are some gofmt changes in 1.13 and Travis has some bug in travis that returns 1.13 for 1.x where it should return latest stable, but my question is should we just run 1.10 or at least run make style only for the laster golang stable.?

[krasi-georgiev]

some initial discussions in #4329 (comment)

[SuperQ]

I don't really know the whole history.

[simonpasquier]

At least it isn't uniform across projects since AlertManager (at least) tests only against 1.10.x (which is pulling the correct version).

[brancz]

Not sure how to ensure this as our setup is quite entangled regarding this, but it sounds like we should run everything with the same version as we’re compiling the target binary with promu.

[krasi-georgiev]

ok , thanks

@simonpasquier do you want to update your PR #4331 to remove the 1.x alltogether so we can fix the tests and will revisit if needed.

[simonpasquier]

@krasi-georgiev this is done.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.