Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter for prometheus query engine queries #4334

Closed
d-shi opened this Issue Jul 2, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@d-shi
Copy link

d-shi commented Jul 2, 2018

Proposal

Similar to #2325, but add one additional metric that is a counter for number of queries coming in to prometheus query engine. Right now there is a metric called prometheus_engine_queries, which is a gauge. We see that most of the time this gauge has a value of 0 (sometimes one data point will be 1).

We are trying to debug why prometheus_engine_query_duration_seconds latencies spike up to >10 seconds sometimes, and would like to know if it correlates to a massive number of queries coming in, but do not have this metric currently since the gauge is mostly 0 (so at least no real queuing of queries is happening).

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 3, 2018

prometheus_engine_query_duration_seconds_count already covers this.

@d-shi

This comment has been minimized.

Copy link
Author

d-shi commented Jul 3, 2018

Ah, thank you. Sorry didn't see that before.

@d-shi d-shi closed this Jul 3, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.