Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul_sd_configs bug #4366

Closed
zhangjianweibj opened this Issue Jul 10, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@zhangjianweibj
Copy link

zhangjianweibj commented Jul 10, 2018

prometheus version:last
source code: discovery/consul/consul.go
issue:consule service has supported meta property for some time.

image

but prometheus has not updated the corresponding entity.i register a service in consul with some metadata info.but prometheus shows some information without the metadata info.

@zhangjianweibj

This comment has been minimized.

Copy link
Author

zhangjianweibj commented Jul 10, 2018

image

CatalogService type also support serviceMeta

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Jul 10, 2018

@zhangjianweibj IIUC your request matches with #4280 so please comment there. Note that it isn't going to be merged right now because there's a feature moratorium.

@zhangjianweibj

This comment has been minimized.

Copy link
Author

zhangjianweibj commented Jul 11, 2018

@simonpasquier yeah,it is a very useful and necessary feature.wish the PR can be merged as soon as possbile.very thanks.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.