Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTest correct rendering of template-based web endpoints #4417
Comments
juliusv
added
priority/P2
component/ui
component/tests
labels
Jul 25, 2018
juliusv
referenced this issue
Jul 25, 2018
Merged
Update method name in rules template, fix rendering #4416
gouthamve
added
help wanted
low hanging fruit
labels
Feb 1, 2019
This comment has been minimized.
This comment has been minimized.
|
@juliusv would it be ok for me to pick up this issue? |
This comment has been minimized.
This comment has been minimized.
|
Please go ahead. |
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil do you have any advice on how I should test endpoints that have |
minhlongdo
referenced this issue
Feb 6, 2019
Merged
Add rendering test of template based web endpoints #5188
This comment has been minimized.
This comment has been minimized.
|
I don't see why those would be any different to test. |
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil I guess this issue can be closed? |
brian-brazil
closed this
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
juliusv commentedJul 25, 2018
See #4416
The template-based web endpoints such as
/alerts,/rules, etc., refer to Go variable and method names that the compiler cannot statically verify. When the Go names get renamed, it breaks the templates without anyone noticing. It would be good to have some kind of e2e test that at least checks whether those pages render without an error.