Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtool 2.3.2 fails if adding sample_limit in "global" section #4466

Closed
identificator1 opened this Issue Aug 6, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@identificator1
Copy link

identificator1 commented Aug 6, 2018

promtool, version 2.3.2
If to add sample_limit in global section

  prometheus.yml:
    global:
      sample_limit: 50000
  - job_name: 'my_job'
...

it fails:
promtool we get an error: field sample_limit not found in type config.plain

Running promtheus:
load configuration (--config.file=/etc/prometheus/prometheus.yml): parsing YAML file /etc/prometheus/prometheus.yml: unknown fields in global config: sample_limit"

If to add in scrape_configs section in job - works fine.

scrape_configs:
 - job_name: 'my_job'
   sample_limit: 5000
@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Aug 6, 2018

This is working as expected: there's no global sample_limit parameter.

https://prometheus.io/docs/prometheus/latest/configuration/configuration/#configuration-file

I'm closing it for now. If you have further questions, please use our user mailing list, which you can also search.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.