Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proper tests for crash recovery. #447

Closed
beorn7 opened this Issue Jan 12, 2015 · 2 comments

Comments

Assignees

@beorn7 beorn7

Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
3 participants
@beorn7 @fabxc @brian-brazil
@beorn7
Copy link
Member

beorn7 commented Jan 12, 2015

See TODOs in the code (but this is significant enough to warrant an own issue here.)

@beorn7 beorn7 self-assigned this Mar 3, 2015

@brian-brazil brian-brazil added the enhancement label Dec 16, 2015

@fabxc fabxc added kind/enhancement and removed enhancement labels Apr 28, 2016

beorn7 added a commit that referenced this issue Jul 7, 2016

@beorn7
Crash recovery: Fix an edge case. 
If the chunks of a series in the checkpoint are all older then the
latest chunk on disk, the head chunk is persisted and therefore has to
be declared closed.

It would be great to have a test for this, but that would require more
plumbing, subject of #447.
Loading status checks…
2a75b15

@beorn7 beorn7 referenced this issue Jul 7, 2016

Merged

Crash recovery: Fix an edge case. #1798

@beorn7 beorn7 referenced this issue Sep 9, 2016

Closed

Recover from LevelDB corruptions #1967

@beorn7 beorn7 referenced this issue Oct 31, 2016

Closed

Investigate RAM consumption during crash recovery #2139

@beorn7

This comment has been minimized.

Sign in to view
Copy link
Member Author

beorn7 commented Apr 4, 2017

Crash recovery will be done completely differently in v2.0.

There is no point in creating an involved test setup for the existing crash recovery anymore.

@beorn7 beorn7 closed this Apr 4, 2017

@beorn7 beorn7 added the reviewed/won't fix label Apr 4, 2017

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.